-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] [browser] make dynamic import cancelable #80312
[release/7.0] [browser] make dynamic import cancelable #80312
Conversation
Tagging subscribers to 'arch-wasm': @lewing |
Removing |
The CI fail is unrelated here and re-run didn't help. |
@pavelsavara please make sure to fill out the template explaining how the issue affects customers and how the fix will address it. Once that's done, please send email to Tactics requesting merge approval,. and add the |
The CI failure in dev-innerloop is known and unrelated: #80284 |
Thanks, I updated the description. |
Approved by Tactics via email (7.0.3). |
Backport of #80257 to release/7.0
The underlying dynamic
import()
API of the browser is not cancelable.During design of the C# API we added the cancelation token because we do that on all async methods.
We also added the C# code which would cancel/abandon the JS promise.
But we forgot to make the JS promise ready for that.
This PR fixes the omission.
It doesn't really cancel the JS download, nor execution of the module as that's not possible.
But it at least would stop blocking the caller.
Customer Impact
Fixes customer reported issue #80028
Testing
Unit test
Risk
Low, new API in Net7