-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #79136
Fix typos #79136
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsAlso cleaned up trailing whitespaces in the changeset files.
|
@@ -14,7 +14,7 @@ namespace System.ComponentModel.Composition.Hosting | |||
/// queryable state along with a sequence of actions necessary to complete the state when | |||
/// the atomicComposition is no longer in danger of being rolled back. State is completed or | |||
/// rolled back when the atomicComposition is disposed, depending on the state of the | |||
/// CompleteOnDipose property which defaults to false. The using(...) pattern in C# is a | |||
/// CompleteOnDispose property which defaults to false. The using(...) pattern in C# is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not such property (even in the initial MEF1 port a6f350f).
Another frequent typo is in System.Threading.Tasks.TaskCanceledException where cancelled is always spelled with one "L", including in error messages. An example instance is: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Threading.Tasks/ref/System.Threading.Tasks.Forwards.cs#L30 |
This type name is a public contract. We don't change public contracts when fixing typos in bulk. BTW, both spellings are correct:
and here are some quick stats which show that this repo favors single L spelling (though both are in use): # count occurrences: 'cancelled' vs. 'canceled'
$ git grep -i cancelled | wc -l
580
$ git grep -i canceled | wc -l
4477 |
3706149
to
140fa72
Compare
CI failures are unrelated to changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Commit migrated from dotnet/runtime@3855a99
Also cleaned up trailing whitespaces in the changeset files.