-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Runtime_76194 test #78760
Fix Runtime_76194 test #78760
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsShould fix #78758 cc @jakobbotsch
|
/azp list |
This comment was marked as outdated.
This comment was marked as outdated.
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/tests/JIT/Regression/JitBlue/Runtime_76194/Runtime_76194.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
returns -1 on
@jkotas @jakobbotsch does it ring a bell to you by any chance what could be the reason? |
I think the problem might be that the value of Likely you can pinvoke this SystemNative version and it will handle the conversions for us? |
This also explains why we only were seeing this issue in outerloop runs. |
If the tests need native dependencies, we typically create a test local native dependency for the tests that does what the test needs. |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/tests/JIT/Regression/JitBlue/Runtime_76194/CrossplatVirtualAlloc.cpp
Outdated
Show resolved
Hide resolved
src/tests/JIT/Regression/JitBlue/Runtime_76194/CrossplatVirtualAlloc.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
@dotnet/jit-contrib @jkotas PTAL, this unblocks outerloop CI |
src/tests/JIT/Regression/JitBlue/Runtime_76194/Runtime_76194.csproj
Outdated
Show resolved
Hide resolved
src/tests/JIT/Regression/JitBlue/Runtime_76194/CrossplatVirtualAlloc.cpp
Outdated
Show resolved
Hide resolved
…lAlloc.cpp Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Had to disable the test for some mono targets: Wasm, Android, iOS where other tests with native libs are also ignored. |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Should fix #78758
cc @jakobbotsch