[release/7.0] Fix commit accounting for large pages #78564
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #78531 to release/7.0 /cc @cshung Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@cshung @mangod9 do we intend to include this in the January release? If yes, please make sure it's ready to merge before Nov. 29th. I see this is still a draft. I ask because for the January release, we will only have a one day window to merge servicing PRs, so I want to make sure all the PRs are 100% ready on that day for me to just click the merge button. That window is from Nov. 29th to Nov. 30th. Pending things to address:
|
|
Hi @carlossanlop, can we get this PR merged before the merge window ends? I believe we have gone through all the aforementioned steps to ensure this is ready i.e. filled in the template and got approval. Thanks! |
|
@mrsharm can't. We need to wait for branding to happen first. |
|
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI is green. |
Backport of #78531 to release/7.0
/cc @cshung
Customer Impact
The impact of this bug is constrained to users with large pages enabled and this PR fixes the commit accounting so that we don't prematurely OOM. We discovered this issue while investigating a first party customer's out of memory (OOM) issue after upgrading to .NET 7 with regions enabled.
Testing
We were able to reproduce this issue locally and tested that with the fix, the OOM didn't occur. The first party team has additionally confirmed that we are no longer OOM'ing with the patched fix. Additionally, they have been continuing to test this for a couple of days without issue; previously their process would throw an OOM before initialization.
Risk
The risk here is constrained to where large pages are enabled, and the rest of the code path is the same. This is a fix for the aforementioned bug described above and therefore, it should reduce the risk of users getting into an OOM.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.