Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Add IMemoryView as exported type #77397

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2022

Backport of #77371 to release/7.0

/cc @maraf

Customer Impact

Users using typescript can see definition of IMemoryView interface used in JavaScript interop

Testing

Manual. The dotnet.d.ts contains the IMemoryView.

Risk

None.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@carlossanlop
Copy link
Member

@maraf if this is ready, please add the servicing-consider label and send an email to Tactics requesting approval to merge.

@maraf maraf added the Servicing-consider Issue for next servicing release review label Oct 31, 2022
@maraf
Copy link
Member

maraf commented Nov 2, 2022

Received approval by email.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 3, 2022
@carlossanlop
Copy link
Member

Approved by Tactics via email.
No OOB package authoring changes needed for this.
Signed off by area owner.
CI failures is unrelated to this change and was fixed in #76939
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 4c3001d into release/7.0 Nov 3, 2022
@carlossanlop carlossanlop deleted the backport/pr-77371-to-release/7.0 branch November 3, 2022 00:16
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants