-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Wasm.Build.Tests: Use the default cache for emcc #76694
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsOn windows, WBT overrides the cache path to a new directory. And sets And if we don't do the above, then the builds would be using the default This improves the test run times by 18-20mins per test class.
|
On windows, WBT overrides the cache path to a new directory - `~/.emscripten-cache`. Because of this the first native build takes a long time (~16-20mins) as it run `embuilder build MINIMAL`. Instead, we can use the new workload pack for emscripten Cache, which is the default behavior. So, not overriding the cache path improves the test run times on windows by ~17-20mins.
bd1d593
to
4bc0b4f
Compare
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
Should we also drop it here ? runtime/eng/testing/tests.wasm.targets Line 107 in c075692
|
That requires some extra work, and I'm working on that in a separate PR. |
On windows, WBT overrides the cache path to a new directory -
~/.emscripten-cache
. Because of this the first native build takes along time (~16-20mins) as it run
embuilder build MINIMAL
.Instead, we can use the new workload pack for emscripten Cache, which is
the default behavior. So, not overriding the cache path improves the
test run times on windows by ~17-20mins.
robocopy
, which saves ~5mins .