Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] CI: Run runtime-extra-platforms with batched builds for release #76615

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

radical
Copy link
Member

@radical radical commented Oct 4, 2022

Backport of PR #76587 .

Currently, for release/* branches, the pipeline is run twice a day, if there are any changes since the last successful run. In contrast, the runtime pipeline only runs batched builds for the release branches.

This can get into a situation like:

  1. commit ABC pushed to the release branch
  2. runtime builds for ABC -- batched build
  3. runtime-extra-platforms builds on a schedule, but this pipeline is unstable, and fails.
  4. runtime-extra-platforms now runs twice a day, till we have a new commit, because the pipeline is never green

Instead, this changes the behavior to match runtime pipeline, and only run batched builds.

Customer impact

Infrastructure only change, so no customer impact.

Testing

Manual testing

Risk

none

…tnet#76587)

.. branches.

Currently, for `release/*` branches, the pipeline is run twice a day, if
there are any changes since the last *successful* run. In contrast, the
`runtime` pipeline only runs batched builds for the release branches.

This can get into a situation like:
1. commit ABC pushed to the release branch
2. `runtime` builds for ABC -- batched build
3. `runtime-extra-platforms` builds on a schedule, but this pipeline is
   unstable, and fails.
4. `runtime-extra-platforms` now runs twice a day, till we have a new
   commit, because the pipeline is never green

Instead, this changes the behavior to match `runtime` pipeline, and only
run batched builds.
@radical radical added this to the 7.0.0 milestone Oct 4, 2022
@ghost ghost assigned radical Oct 4, 2022
@ghost
Copy link

ghost commented Oct 4, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of PR #76587 .

Currently, for release/* branches, the pipeline is run twice a day, if there are any changes since the last successful run. In contrast, the runtime pipeline only runs batched builds for the release branches.

This can get into a situation like:

  1. commit ABC pushed to the release branch
  2. runtime builds for ABC -- batched build
  3. runtime-extra-platforms builds on a schedule, but this pipeline is unstable, and fails.
  4. runtime-extra-platforms now runs twice a day, till we have a new commit, because the pipeline is never green

Instead, this changes the behavior to match runtime pipeline, and only run batched builds.

Customer impact

Infrastructure only change, so no customer impact.

Testing

Manual testing

Risk

none

Author: radical
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@radical radical added the Servicing-consider Issue for next servicing release review label Oct 4, 2022
@lewing lewing removed the Servicing-consider Issue for next servicing release review label Oct 4, 2022
@lewing
Copy link
Member

lewing commented Oct 4, 2022

this is just infrastructure no need to involve tactics

@lewing
Copy link
Member

lewing commented Oct 4, 2022

@akoeplinger @steveisok can one of you sign off

@radical
Copy link
Member Author

radical commented Oct 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Oct 4, 2022

Canceled the runtime-extra-platforms run. I had triggered it just to check that there weren't any yml issues.

@radical
Copy link
Member Author

radical commented Oct 4, 2022

@carlossanlop ready to go!

@carlossanlop
Copy link
Member

Approved, CI verified, infra-only change. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 8743673 into dotnet:release/7.0 Oct 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants