[release/7.0] Disable gen 1 budget accounting fix for segments #76412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation of GC behaves like .NET 6.0 did.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #76365 to release/7.0 /cc @Maoni0 @PeterSolMS Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
approved these changes
Sep 30, 2022
Maoni0
approved these changes
Sep 30, 2022
|
Approved by Tactics via email. Signed off. CI is green. This is fully baked and ready to merge. |
|
@carlossanlop the 'no-merge' as on this one as we were still discussing. @Maoni0 with your signoff is it all good? |
|
all good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76365 to release/7.0
/cc @Maoni0 @PeterSolMS
Customer Impact
Given that we expect some customers will see working set or performance regressions with regions, we want to make sure that clrgc.dll using segments performs just like .NET 6.0 did. So this change disables a gen 1 budget tuning change we did in the 7.0 time frame.
Testing
Ran GCPerfSim scenarios on both WKS and SVR, for both regions and segments.
Risk
Risk should be small because we are undoing a change introduced in 7.0. There is no change for regions, only for segments. Also change is minimal and straightforward.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.