Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][arm] Fix rethrow instruction size #76387

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Sep 29, 2022

It is the same as throw

Fixes #76192

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrzVlad this is safe to backport, I think?

@lambdageek
Copy link
Member

Do we have some lane to run arm32 device tests? @steveisok

@BrzVlad
Copy link
Member Author

BrzVlad commented Sep 29, 2022

@BrzVlad this is safe to backport, I think?

Yes. I would backport it also to 6.0 where the user hit this issue

@lambdageek
Copy link
Member

/backport to release/7.0

@lambdageek
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3153124634

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3153126207

@radical
Copy link
Member

radical commented Sep 29, 2022

The WBT failure can be ignored.

@steveisok
Copy link
Member

Do we have some lane to run arm32 device tests? @steveisok

We run tests for arm on android devices.

@BrzVlad
Copy link
Member Author

BrzVlad commented Sep 30, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad BrzVlad merged commit 200f533 into dotnet:main Oct 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[android] unknown opcode name for 400, only workaround is UseInterpreter=true
6 participants