Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List<T> AddRange, InsertRange, and CopyTo extensions for spans #76274

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Add List<T> AddRange, InsertRange, and CopyTo extensions for spans #76274

merged 4 commits into from
Sep 29, 2022

Conversation

stephentoub
Copy link
Member

Fixes #1530

@stephentoub stephentoub added this to the 8.0.0 milestone Sep 27, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #1530

Author: stephentoub
Assignees: -
Labels:

area-System.Collections
Milestone: 8.0.0

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Sep 27, 2022
eiriktsarpalis
eiriktsarpalis approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub @eiriktsarpalis
Update src/libraries/System.Private.CoreLib/src/System/Collections/Ge…
55c1370 
…neric/CollectionExtensions.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@stephentoub @eiriktsarpalis
Update src/libraries/System.Private.CoreLib/src/System/Collections/Ge…
9d758d3 
…neric/CollectionExtensions.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@stephentoub stephentoub merged commit 1d62590 into dotnet:main Sep 29, 2022
@stephentoub stephentoub deleted the listextensions branch September 29, 2022 02:11
@lewing lewing mentioned this pull request Oct 6, 2022
Open
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
@jeffhandley jeffhandley added the blog-candidate Completed PRs that are candidate topics for blog post coverage label Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@eerhardt eerhardt eerhardt left review comments

Assignees

@stephentoub stephentoub

Labels
area-System.Collections blog-candidate Completed PRs that are candidate topics for blog post coverage new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

API for inserting a Span<T> into a List<T> efficiently
4 participants
@stephentoub @eiriktsarpalis @eerhardt @jeffhandley