Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers dotnet/runtime-assets #76243

Merged
merged 10 commits into from
Oct 5, 2022
Merged

[release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers dotnet/runtime-assets #76243

merged 10 commits into from
Oct 5, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 27, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/llvm-project

  • Subscription: dc7edec6-2e27-40ef-139c-08da7ef5fa55
  • Build: 20221004.1
  • Date Produced: October 4, 2022 1:13:19 PM UTC
  • Commit: 58e84beae1d2cbfc99a98ae5d59bcbd337120a42
  • Branch: refs/heads/dotnet/release/7.0

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: a8b74935-5a68-4a8e-b089-08da7ef6355d
  • Build: 20221004.1
  • Date Produced: October 4, 2022 8:52:34 AM UTC
  • Commit: 846a766f73caa82608db6fee9f2860004298449f
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: f62fea6e-d057-4466-663e-08da7ef6346a
  • Build: 20220926.1
  • Date Produced: September 26, 2022 1:21:14 PM UTC
  • Commit: 70dcb3d50e3d2c8064f662f9f79b55bd5a875385
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 35e57660-6174-46f6-8166-08da7ef6284d
  • Build: 2022100.1
  • Date Produced: October 3, 2022 1:19:30 PM UTC
  • Commit: ce7e603e0d3ef63bcb2f99139b1dd3dc9b837a2d
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
cd3e7b6 
… 20220926.2

runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22469.2 -> To Version 11.1.0-alpha.1.22476.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Sep 27, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
99483b3 
…uild 20220926.2

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22471.2 -> To Version 7.0.0-preview1.22476.2
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers Sep 27, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
188829e 
…ild 20220926.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.1.0-alpha.0.22470.1 -> To Version 1.1.0-alpha.0.22476.1
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers dotnet/hotreload-utils Sep 27, 2022
@lewing
Copy link
Member

lewing commented Sep 27, 2022

@lambdageek are these genuine hotreload problems?

@lambdageek
Copy link
Member

are these genuine hotreload problems?

I don't think so. It looks like a codeflow problem - hotreload-utils wants a newer SDK than what the runtime depends on.

App: /__w/1/s/.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/1.1.0-alpha.0.22476.1/tools/net7.0/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.dll
  Architecture: x64
  Framework: 'Microsoft.NETCore.App', version '7.0.0-rc.1.22426.10' (x64)
  .NET location: /__w/1/s/.dotnet/
  
  The following frameworks were found:
    7.0.0-rc.1.22423.16 at [/__w/1/s/.dotnet/shared/Microsoft.NETCore.App]
  
  Learn about framework resolution:
  https://aka.ms/dotnet/app-launch-failed

So it's trying to run the hot reload delta generator tool and the SDK that the runtime depends on is older than the SDK that the tool depends on.

Maybe we should disable the codeflow from hotreload-utils/main to runtime/release/7.0 ?

@carlossanlop
Copy link
Member

Maybe we should disable the codeflow from hotreload-utils/main to runtime/release/7.0 ?

I can do that if that's what people want. @lewing, any objections? Anyone else we should ask?

@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers dotnet/hotreload-utils [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/hotreload-utils dotnet/llvm-project Sep 28, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/hotreload-utils dotnet/llvm-project [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils Sep 28, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers Sep 28, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project Sep 29, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils Sep 29, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers Sep 29, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project Sep 30, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils Sep 30, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/hotreload-utils [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers Sep 30, 2022
@carlossanlop
Copy link
Member

Maybe we should disable the codeflow from hotreload-utils/main to runtime/release/7.0 ?

I can do that if that's what people want. @lewing, any objections? Anyone else we should ask?

I see @akoeplinger and @lambdageek are the top contributors in that repo. I disabled it:

Will disable the following 1 subscriptions...
  https://github.com/dotnet/hotreload-utils (.NET 7) ==> 'https://github.com/dotnet/runtime' ('release/7.0')
Continue? (y/n) y
Disabling 1 subscriptions...done

@carlossanlop
Copy link
Member

Should I revert the hotreload-utils dependency change in this PR?

carlossanlop
carlossanlop reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger @lambdageek LMK if I should apply these revert suggestions:

@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project Oct 1, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
99944de 
…uild 20220930.2

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22471.2 -> To Version 7.0.0-preview1.22480.2
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers Oct 1, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project Oct 2, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
48ca61a 
…uild 20221001.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22471.2 -> To Version 7.0.0-preview1.22501.1
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers Oct 2, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project Oct 3, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers Oct 3, 2022
@akoeplinger
Copy link
Member

@carlossanlop yeah let's do that

carlossanlop
carlossanlop reviewed Oct 3, 2022
View reviewed changes
@carlossanlop carlossanlop changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers Oct 3, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime-assets build
a477719 
2022100.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 7.0.0-beta.22476.1 -> To Version 7.0.0-beta.22503.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
2888321 
…uild 20221004.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22471.2 -> To Version 7.0.0-preview1.22504.1
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers Oct 4, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
d9188e2 
… 20221004.1

runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22469.2 -> To Version 11.1.0-alpha.1.22504.1
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project Oct 5, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/runtime-assets dotnet/llvm-project dotnet/roslyn-analyzers Oct 5, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/runtime-assets dotnet/llvm-project dotnet/roslyn-analyzers [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project dotnet/roslyn-analyzers dotnet/runtime-assets Oct 5, 2022
carlossanlop
carlossanlop approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are:

Approving and merging before the bot decides to update the PR again.

@carlossanlop carlossanlop merged commit 9d73ae9 into release/7.0 Oct 5, 2022
@carlossanlop carlossanlop deleted the darc-release/7.0-fdcb397e-998b-4084-bbec-ebc0e4eec482 branch October 5, 2022 22:46
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewing @lambdageek @carlossanlop @akoeplinger