[release/7.0] JIT: Fix segfault for modulo computations involving address-of expressions #76171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trees We may get here for any invariant dividend/divisor but these can be 'complex' address-of trees that gtClone does not handle. Fix #76051
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #76061 to release/7.0 /cc @jakobbotsch Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@jakobbotsch if this is ready, please add the |
jeffschwMSFT
approved these changes
Sep 26, 2022
EgorBo
approved these changes
Sep 26, 2022
AndyAyersMS
approved these changes
Sep 26, 2022
|
Approved by Tactics, CI is green, signed off. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76061 to release/7.0
/cc @jakobbotsch
Customer Impact
Code that computes remainder where an operand is an address-of expression will crash the JIT on arm64 platforms.
For example, the following code crashes during JIT in .NET 7:
https://github.com/VSadov/NonBlocking/blob/e2bd82f6ebe80a81b769d8195aae22e3d2e19441/src/NonBlocking/Counter/CounterBase.cs#L32-L37
Reported by customer in #76051. This is a regression from .NET 6.
Testing
Regression test included.
Risk
Low.