[release/7.0] Add missing DynamicallyAccessMembers attributes to System.Data.Common/ref #75980
Conversation
The existing APICompat tooling doesn't indicate a compatibility error when comparing the contract assembly against the implementation assembly and the `[return: ...]` attributes aren't in sync. The new tooling that is being bootstrapped in dotnet/runtime via #73263 does flag them. In this case a few type members were missing the `DynamicallyAccessedMembers` return attribute in the contract.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsBackport of #75961 to release/7.0 /cc @ViktorHofer Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@ericstj @danmoseley unsure if this an ask-mode or tell-mode change. Happy to send it to Tactics if necessary. |
|
Since it touches the shipping reference assembly let's run it through ask mode. |
Backport of #75961 to release/7.0
/cc @ViktorHofer
Customer Impact
Having these attributes on the contract when they are present in the implementation is important. To quote @eerhardt:
Testing
Manually verified that the missing attributes are part of the contract assembly. Automation to prevent this divergence will be added with #73263.
Risk
Low. The attributes were missing before and are now part of the assembly. We'll now introduce the correct warnings for these APIs when projects opt-into the analyzer.