Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc2] Handle a null szPname field #75716

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 15, 2022

Backport of #75695 to release/7.0-rc2

/cc @stephentoub @jkoritzinsky

Customer Impact

NullReferenceException when upgrading from .NET 6 to .NET 7 RC 1 in System.Speech on Windows.

Testing

Verified locally that the exception happens before the fix and does not happen after the fix.

Risk

Low

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 15, 2022

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75695 to release/7.0-rc2

/cc @stephentoub @jkoritzinsky

Customer Impact

NullReferenceException when upgrading from .NET 6 to .NET 7 RC 1

Testing

Risk

Low

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Speech

Milestone: -

@jkoritzinsky
Copy link
Member

@danmoseley it looks like the update to the unit test doesn't work, maybe because trying to output to the audio device in the VM configurations we use for testing fails?

@danmoseley
Copy link
Member

@danmoseley it looks like the update to the unit test doesn't work, maybe because trying to output to the audio device in the VM configurations we use for testing fails?

Hmm, now you know the regkey, if you set that locally, but don't have this extra line in the test, does it repro? (ie., the line is unnecessary -- I assume so). If so -- we're good.

Please send tactics mail for this. thanks for fixing.

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Sep 16, 2022

I locally tested with a smaller sample (the two lines from the original issue), not with the unit test, to get the repro locally

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Sep 16, 2022
@jeffschwMSFT jeffschwMSFT added this to the 7.0.0 milestone Sep 16, 2022
@carlossanlop
Copy link
Member

CI failures are a couple of cancelations due to timeouts during job initialization. Unrelated.
Approved and signed off. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit fdca698 into release/7.0-rc2 Sep 16, 2022
@carlossanlop carlossanlop deleted the backport/pr-75695-to-release/7.0-rc2 branch September 16, 2022 16:26
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Speech Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants