-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc2] Handle a null szPname field #75716
[release/7.0-rc2] Handle a null szPname field #75716
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @danmoseley Issue DetailsBackport of #75695 to release/7.0-rc2 /cc @stephentoub @jkoritzinsky Customer ImpactNullReferenceException when upgrading from .NET 6 to .NET 7 RC 1 TestingRiskLow IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@danmoseley it looks like the update to the unit test doesn't work, maybe because trying to output to the audio device in the VM configurations we use for testing fails? |
Hmm, now you know the regkey, if you set that locally, but don't have this extra line in the test, does it repro? (ie., the line is unnecessary -- I assume so). If so -- we're good. Please send tactics mail for this. thanks for fixing. |
I locally tested with a smaller sample (the two lines from the original issue), not with the unit test, to get the repro locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
CI failures are a couple of cancelations due to timeouts during job initialization. Unrelated. |
Backport of #75695 to release/7.0-rc2
/cc @stephentoub @jkoritzinsky
Customer Impact
NullReferenceException when upgrading from .NET 6 to .NET 7 RC 1 in System.Speech on Windows.
Testing
Verified locally that the exception happens before the fix and does not happen after the fix.
Risk
Low
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.