Use AzDO Pipeline Resources to define our build Docker containers #75473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsRefactor all of the docker images we use in our build into AzDO container resources. Also update all of our pipelines (we have a lot) to use this new format. This enables a few things:
The vast majority of changes in this PR are whitespace changes. I highly recommend viewing changes either side-by-side (to validate YAML whitespace changes) or with whitespace changes hidden (for the more interesting logic changes in the YAML).
|
1c682f1 to
972bcdf
Compare
…iner resources. Also update all of our pipelines (we have a lot) to use this new format. This enables a few things: 1. We can pass the ROOTFS_DIR environment variable as part of the container. 2. Docker container names are better centralized in an easier to read and easier to parse file. Fix typo in template name Pipeline template parameters are declared differently for some reason (and are strongly typed) Fix runtime and runtime-llvm pipeilne defs Explicitly reference mcr.microsoft.com
606928f to
faee2c3
Compare
akoeplinger
reviewed
Oct 4, 2022
akoeplinger
approved these changes
Oct 4, 2022
hoyosjs
approved these changes
Oct 4, 2022
|
Files #76750 for the timeout |
directhex
added a commit
to directhex/runtime
that referenced
this pull request
Oct 7, 2022
directhex
added a commit
that referenced
this pull request
Oct 7, 2022
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Nov 2, 2022
Fallout from dotnet#75473, container handling happens in platform-matrix.yml now.
ViktorHofer
pushed a commit
that referenced
this pull request
Nov 3, 2022
Fallout from #75473, container handling happens in platform-matrix.yml now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor all of the docker images we use in our build into AzDO container resources.
Also update all of our pipelines (we have a lot) to use this new format.
This enables a few things:
The vast majority of changes in this PR are whitespace changes. I highly recommend viewing changes either side-by-side (to validate YAML whitespace changes) or with whitespace changes hidden (for the more interesting logic changes in the YAML).