Extensions.Logging.Console: Only check for Android/Apple mobile on netcoreapp configs #74798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcoreapp configs We can keep the previous behavior on non-netcoreapp configs since they only apply to legacy Xamarin.iOS/Android. That allows us to use the more efficient `OperatingSystem.Is*()` APIs.
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsWe can keep the previous behavior on non-netcoreapp configs since they only apply to legacy Xamarin.iOS/Android.
|
akoeplinger
commented
Aug 30, 2022
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
mkhamoyan
approved these changes
Aug 30, 2022
jkotas
reviewed
Aug 30, 2022
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsWe can keep the previous behavior before #74496 on non-netcoreapp configs since they only apply to legacy Xamarin.iOS/Android.
|
jkotas
reviewed
Aug 30, 2022
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
…onsoleFormatter.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
tarekgh
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can keep the previous behavior before #74496 on non-netcoreapp configs since they only apply to legacy Xamarin.iOS/Android.
That allows us to use the more efficient
OperatingSystem.Is*()APIs.