Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mono package versions during stabilization #74353

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

ViktorHofer
Copy link
Member

The issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise.

This will also need to be backported into release/7.0-rc1.

The issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise.
@ViktorHofer ViktorHofer requested a review from a team August 22, 2022 16:08
@ViktorHofer ViktorHofer self-assigned this Aug 22, 2022
@ViktorHofer
Copy link
Member Author

cc @akoeplinger

@ghost
Copy link

ghost commented Aug 22, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

The issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise.

This will also need to be backported into release/7.0-rc1.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

@steveisok steveisok self-requested a review August 22, 2022 16:23
<PropertyGroup>
<!-- Central place to set the versions of all mono pkgprojs. -->
<PackageVersion Condition="'$(PackageVersion)' == ''">$(ProductVersion)</PackageVersion>
<StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coreclr version of this also checks for '$(PreReleaseVersionLabel)' != 'servicing' do we need this here too?

<StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == '' and '$(PreReleaseVersionLabel)' != 'servicing'">$(PackageVersion)</StableVersion>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as the coreclr packages intentionally don't ship during servicing which isn't true for the mono packages.

@ViktorHofer ViktorHofer merged commit b966a10 into main Aug 22, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch August 22, 2022 18:15
@ViktorHofer
Copy link
Member Author

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2906141406

@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants