-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mono package versions during stabilization #74353
Conversation
The issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise.
cc @akoeplinger |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise. This will also need to be backported into release/7.0-rc1.
|
<PropertyGroup> | ||
<!-- Central place to set the versions of all mono pkgprojs. --> | ||
<PackageVersion Condition="'$(PackageVersion)' == ''">$(ProductVersion)</PackageVersion> | ||
<StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the coreclr version of this also checks for '$(PreReleaseVersionLabel)' != 'servicing'
do we need this here too?
<StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == '' and '$(PreReleaseVersionLabel)' != 'servicing'">$(PackageVersion)</StableVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as the coreclr packages intentionally don't ship during servicing which isn't true for the mono packages.
/backport to release/7.0-rc1 |
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2906141406 |
The issues that are being fixed via this PR happened and were fixed during the 7.0 stabilization release exercise.
This will also need to be backported into release/7.0-rc1.