Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Directory.CreateDirectory: create missing parents using default UnixFileMode. #74277

Merged
merged 7 commits into from
Aug 20, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2022

Backport of #74002 to release/7.0-rc1

/cc @jozkee @tmds

Customer Impact

Avoids creating directories with undesired permissions and makes our API consistent with Linux tools.

Testing

Test cases were added and passed on main, also extra-platforms were exercised.

Risk

Low, the APIs affected were newly added in 7.0.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74002 to release/7.0-rc1

/cc @jozkee @tmds

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.IO

Milestone: -

@jozkee
Copy link
Member

jozkee commented Aug 19, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley
Copy link
Member

Approved offline.

@danmoseley
Copy link
Member

cc @eerhardt

@danmoseley
Copy link
Member

Failures are "No hay más extremos disponibles desde el asignador de extremos." .. "No more endpoints are available from the endpoint mapper."

rerunning.

@carlossanlop
Copy link
Member

Approved.
Signed off by area owner.
CI failures are unrelated.
Ready to merge.

@carlossanlop carlossanlop merged commit 8196f9a into release/7.0-rc1 Aug 20, 2022
@carlossanlop carlossanlop deleted the backport/pr-74002-to-release/7.0-rc1 branch August 20, 2022 17:57
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants