Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Unwrap exception when calling entrypoint #74235

Merged
merged 2 commits into from
Aug 20, 2022
Merged

[wasm] Unwrap exception when calling entrypoint #74235

merged 2 commits into from
Aug 20, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 19, 2022

Introduced in the new entrypoint API. TargetInvocationException should be unwrapped to get the real error message to the client.

@maraf maraf self-assigned this Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduced in the new entrypoint API. TargetInvocationException should be unwrapped to get the real error message to the client.

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: -

@maraf
Copy link
Member Author

maraf commented Aug 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Aug 19, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2891028250

@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Merged
jeffschwMSFT
jeffschwMSFT reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraf maraf merged commit 1d94433 into dotnet:main Aug 20, 2022
@maraf maraf deleted the WasmEntrypointUnwrapException branch August 20, 2022 08:20
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@radical radical Awaiting requested review from radical

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maraf @lewing @jeffschwMSFT