-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ppc64le] Added memory patch thunking for function calls #73616
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@vargaz The assertion mentioned in issue 71080 - "Assertion at /home/directhex/Projects/runtime/src/mono/mono/mini/mini-ppc.c:5080, condition `ppc_is_imm16 (inst->inst_offset)' not met" is observed only in Release mode which we are looking at. Also, there are new test cases added in RegexPcreTests.cs file which are also failing on Power and hence looking into it as well. We are targeting this PR for RC1 release. Can you please review it? |
@vargaz can you please review this PR? We are targeting it for RC1 which is planned on 12th August . |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
@vargaz is on vacation right now, I've triggered a CI run to see if the test is fixed and we can merge the PR and he can review when he is back. |
@akoeplinger |
Ok |
This PR implements memory patch thunking for function calls atomically. This fixes sporadic crashes due to code being patched non-atomically including crashes observed in System.Text.RegularExpressions.Tests. This is similar to what was implemeted for s390x in PR 52783