Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate unwind info files #73129

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 31, 2022

These three files are identical, we can include them from shared external directory.

cc @lambdageek

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 31, 2022
@ghost
Copy link

ghost commented Jul 31, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

These three files are identical, we can include them from shared external directory.

cc @lambdageek

Author: am11
Assignees: -
Labels:

area-Infrastructure-mono, community-contribution

Milestone: -

@vargaz
Copy link
Contributor

vargaz commented Jul 31, 2022

freebsd-elf_common.h is not actually the same, it has an extra RISC definition in the mono version.

@am11
Copy link
Member Author

am11 commented Jul 31, 2022

@vargaz, good catch. I have added it and cross referenced with upstream PR libunwind/libunwind#398.

@AaronRobinsonMSFT
Copy link
Member

Failure appears to be #72830

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit d2264b2 into dotnet:main Aug 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants