Handle blittable byref returns in built-in marshalling #72433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Jul 19, 2022
| { | ||
| var pointedAtType = type.GetParameterType(); | ||
| if (!pointedAtType.IsPrimitive && !type.IsEnum && marshallerType != MarshallerType.Field |
There was a problem hiding this comment.
type.IsEnum was always false here since type was a byref.
jkotas
commented
Jul 19, 2022
| type = type.GetParameterType(); | ||
|
|
||
| if (!type.IsPrimitive && type.IsValueType && marshallerType != MarshallerType.Field | ||
| if (type.IsValueType && !type.IsPrimitive && !type.IsEnum && !isField |
There was a problem hiding this comment.
Trying to make these conditions consistent and more in sync with CoreCLR logic. This path should be only ever used by managed C++ so it does not matter a whole lot anyway.
jkotas
commented
Jul 19, 2022
| { | ||
| ILEmitter emitter = _ilCodeStreams.Emitter; | ||
|
|
||
| _managedHome = new Home(emitter.NewLocal(ManagedParameterType), ManagedParameterType, isByRef: false); |
There was a problem hiding this comment.
We just need to create locals of the right type. The default implementation works fine otherwise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72316