Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYSLIB0044 to diagnostic list #71232

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Jun 23, 2022

Follow up pull request to #70534. This diagnostic is already present in Obsoletions.cs but not the list of diagnostics.

internal const string AssemblyNameCodeBaseMessage = "AssemblyName.CodeBase and AssemblyName.EscapedCodeBase are obsolete. Using them for loading an assembly is not supported.";
internal const string AssemblyNameCodeBaseDiagId = "SYSLIB0044";

@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

This diagnostic is already present in Obsoletions.cs but not the list of diagnostics.

internal const string AssemblyNameCodeBaseMessage = "AssemblyName.CodeBase and AssemblyName.EscapedCodeBase are obsolete. Using them for loading an assembly is not supported.";
internal const string AssemblyNameCodeBaseDiagId = "SYSLIB0044";

Author: vcsjones
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

This diagnostic is already present in Obsoletions.cs but not the list of diagnostics.

internal const string AssemblyNameCodeBaseMessage = "AssemblyName.CodeBase and AssemblyName.EscapedCodeBase are obsolete. Using them for loading an assembly is not supported.";
internal const string AssemblyNameCodeBaseDiagId = "SYSLIB0044";

Author: vcsjones
Assignees: vcsjones
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@stephentoub
Copy link
Member

Thanks

@stephentoub stephentoub merged commit 6321133 into dotnet:main Jun 24, 2022
@vcsjones vcsjones deleted the fix-diagnostic-markdown branch June 24, 2022 02:05
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants