Add exception interop test for validating native exception interop on Windows + CoreCLR. #70110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Windows + CoreCLR.
There was a problem hiding this comment.
LGTM. I'd like to see what @janvorli thinks. I know we have a few tests here and there already. This battery does make me happy but curious if we can remove others and add them to this or fold these into an existing location.
|
@janvorli Any thoughts on this? The value is good but I'd like to avoid duplication if you can point where we already do this or perhaps older tests that can be replaced by what Jeremy has done here. |
|
I am sorry for a late response. There were few weeks when github stopped sending me notifications on comments and I have not realized it. We don't have any tests for this, so I'll be happy to get them in. |
AaronRobinsonMSFT
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test for exception interop to make sure that we have good test coverage for #70109