Add EvaluationResult Scheme for arrays. #67095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsRequires merging in #66654 to work. Objects returned by a method executed on a primitive type do not have an objectId, they don't have their representation on the runtime side either. To be able to get their properties (e.g. elements of array) we are caching them on the debugger side and granting debugger-side-objectId in this PR.
|
thaystg
approved these changes
May 26, 2022
ilonatommy
added a commit
to ilonatommy/runtime
that referenced
this pull request
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires merging in #66654 to work.
Objects returned by a method executed on a primitive type do not have an objectId, they don't have their representation on the runtime side either. To be able to get their properties (e.g. elements of array) we are cacheing them on the debugger side and granting debugger-side-objectId in this PR.