Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MemoryManagerPinLargeArray test as it tests something that we don't ship #66152

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

adamsitnik
Copy link
Member

Explanation: the MemoryManagerPinLargeArray test fails with OOM from time to time, as it tries to allocate a 2GB array and we don't always have the resources to allow for that.

Since it tests the following logic:

if ((uint)elementIndex > (uint)(_array.Length - _offset))
{
throw new ArgumentOutOfRangeException(nameof(elementIndex));
}

that we don't ship (it's an example implementation of MemoryManager<T> derived type) I think that we should just remove it.

fixes #33943

… don't ship and causes trouble as it needs 2 GB of memory
@ghost
Copy link

ghost commented Mar 3, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Explanation: the MemoryManagerPinLargeArray test fails with OOM from time to time, as it tries to allocate a 2GB array and we don't always have the resources to allow for that.

Since it tests the following logic:

if ((uint)elementIndex > (uint)(_array.Length - _offset))
{
throw new ArgumentOutOfRangeException(nameof(elementIndex));
}

that we don't ship (it's an example implementation of MemoryManager<T> derived type) I think that we should just remove it.

fixes #33943

Author: adamsitnik
Assignees: adamsitnik
Labels:

area-System.Memory

Milestone: -

@adamsitnik adamsitnik merged commit 28a7265 into dotnet:main Mar 3, 2022
@adamsitnik adamsitnik deleted the issue33943 branch March 3, 2022 19:35
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure:System.MemoryTests.MemoryTests.MemoryManagerPinLargeArray
2 participants