[release/7.0-preview2][mono][hot reload] Fix sequence point logic for compiler-generated methods in updates #65867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1 means there was some kind of problem 0 means 0 sequence points In particular for mono_ppdb_get_seq_points_enc a compiler-generated method might have 0 sequence points in the PDB delta, but we should consider that as ok, and not fall back to looking in the baseline image
For platforms where we use the remote executor, set the environment variable when starting the remote process. For WASM, pass --setenv when building the project.
marek-safar
approved these changes
Feb 25, 2022
|
I don't have permission to merge to the preview2 branch. Can someone with the right permissions click the squash button. /cc @steveisok |
This comment was marked as outdated.
This comment was marked as outdated.
|
CoreCLR win arm64 failure is #65818 |
|
Needs more work. Something else is going wrong with a real blazor app |
|
Updated the PR to also include all of #65973. I'm not sure if there's still a window to land this in Preview 2 if I go to tactics. /cc @marek-safar |
When hot reload is used with dotnet watch, the baseline PDBs are available, and sequence points are enabled, but there are no PDB updates.
when counting added and modified rows
…tomAttributes capability Roslyn seems to delete nullability annotations sometimes
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65865 and #65973 to
release/7.0-preview2Summary:
This is about fixing the new hot reload capabilities in .NET 7 Preview 1 on platforms that use Mono (Blazor WebAssembly, mobile).
It includes:
dotnet watch) treat added methods as having zero sequence points. This is a follow-up to [mono][hot reload] Fix sequence point logic for compiler-generated methods in updates #65865 which actually makes it possible to add static lambdas.Related to #65808 and #51126
Testing:
new CI tests; manually using the new runtime together with
dotnet watchfrom .NET 7 Preview 1Risks:
Low. This is only for mono workloads; it does not impact existing hot reload capabilities (method body replacement), just the new capabilities to add lambdas and methods that lit up in .NET 7 Preview 1. In case of instability, customers using the next preview can go back to using
dotnet watchto restart the blazor app instead of reloading in place.