Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreCLR runtime tests on Mono Windows x64. #64281

Merged

Conversation

lateralusX
Copy link
Member

@lateralusX lateralusX commented Jan 25, 2022

Analyzed all failures around CoreCLR runtime tests on Mono Windows x64.

Several of the failing test suites (started with 44 failing test suites), are due to missing features, not implemented on Mono on any platform, but many of these tests are not run on none Windows platforms, so have not been an issue in the past. Explicitly included these tests in issues.targets for all mono runtime platforms where we don't run the test suite on none Windows platforms and fail on Windows due to unsupported features in Mono runtime.

Analyzed several test suites that can be fixed in Mono runtime to pass on all platforms, adding fixes to this PR and enable the tests:

  • Several fixes to native custom marshaller.
  • Fixes to extended error reporting in dl_* functions, needed by several native library loader tests.
  • Fix for marshaling issues related to System.Drawings tests.
  • Excluded parts of runtime tests on Mono depending on Windows SEH (similar to what's run on none Windows platforms).
  • Port of [cominterop] Add coop handle enter/return on native CCW methods  mono/mono#21365
  • Fixed failures in valloc on Windows causing assert in OOM situations preventing tests to correctly pass.

PR adds Mono Windows x64 runtime tests to default CI runs.

@lateralusX lateralusX force-pushed the lateralusX/mono-fix-windows-runtime-tests branch from 3dcab04 to 497d460 Compare January 28, 2022 09:59
@lateralusX lateralusX force-pushed the lateralusX/mono-fix-windows-runtime-tests branch 2 times, most recently from 083c7e5 to cc0fb80 Compare February 9, 2022 20:09
@lateralusX lateralusX force-pushed the lateralusX/mono-fix-windows-runtime-tests branch from 498abfc to 6ac2658 Compare February 23, 2022 09:22
@lateralusX lateralusX changed the title WIP: CoreCLR runtime tests on Mono Windows x64. CoreCLR runtime tests on Mono Windows x64. Feb 23, 2022
@lateralusX lateralusX marked this pull request as ready for review February 23, 2022 09:41
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we the native probing difference will be an issue in setups with libraries for multiple platforms available

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@lateralusX lateralusX force-pushed the lateralusX/mono-fix-windows-runtime-tests branch from 55bf253 to a2de84d Compare March 2, 2022 10:21
lateralusX and others added 25 commits March 23, 2022 16:54
# Conflicts:
#	src/mono/mono/metadata/native-library.c
# Conflicts:
#	src/tests/Interop/NativeLibrary/Callback/CallbackStressTest_TargetWindows.csproj
@lateralusX lateralusX force-pushed the lateralusX/mono-fix-windows-runtime-tests branch from 5339a07 to da327f1 Compare March 23, 2022 15:54
@lateralusX lateralusX merged commit 7d1191e into dotnet:main Mar 24, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
Fixed and enabled CoreCLR runtime tests running on Mono Windows x64.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants