-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreCLR runtime tests on Mono Windows x64. #64281
Merged
lateralusX
merged 27 commits into
dotnet:main
from
lateralusX:lateralusX/mono-fix-windows-runtime-tests
Mar 24, 2022
Merged
CoreCLR runtime tests on Mono Windows x64. #64281
lateralusX
merged 27 commits into
dotnet:main
from
lateralusX:lateralusX/mono-fix-windows-runtime-tests
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
reviewed
Jan 25, 2022
lambdageek
reviewed
Jan 25, 2022
lambdageek
reviewed
Jan 25, 2022
lambdageek
reviewed
Jan 26, 2022
3dcab04
to
497d460
Compare
083c7e5
to
cc0fb80
Compare
This was referenced Feb 22, 2022
Open
498abfc
to
6ac2658
Compare
lambdageek
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we the native probing difference will be an issue in setups with libraries for multiple platforms available
...nteropServices.ComDisabled.UnitTests/System.Runtime.InteropServices.ComDisabled.Tests.csproj
Outdated
Show resolved
Hide resolved
steveisok
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
55bf253
to
a2de84d
Compare
# Conflicts: # src/mono/mono/metadata/native-library.c
# Conflicts: # src/tests/Interop/NativeLibrary/Callback/CallbackStressTest_TargetWindows.csproj
5339a07
to
da327f1
Compare
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
Fixed and enabled CoreCLR runtime tests running on Mono Windows x64.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzed all failures around CoreCLR runtime tests on Mono Windows x64.
Several of the failing test suites (started with 44 failing test suites), are due to missing features, not implemented on Mono on any platform, but many of these tests are not run on none Windows platforms, so have not been an issue in the past. Explicitly included these tests in issues.targets for all mono runtime platforms where we don't run the test suite on none Windows platforms and fail on Windows due to unsupported features in Mono runtime.
Analyzed several test suites that can be fixed in Mono runtime to pass on all platforms, adding fixes to this PR and enable the tests:
PR adds Mono Windows x64 runtime tests to default CI runs.