Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Maui Startup testing #64121

Merged
merged 14 commits into from
Jan 31, 2022

Conversation

LoopedBard3
Copy link
Member

This adds the Android Maui Startup scenario to the android_scenarios.proj file and slightly modifies the test.py format to match the new flows arguments. The new flow also enabled the removal of the compilation of the Hello Android app with diagnostics. This work is in tandem with dotnet/performance#2219.

@ghost
Copy link

ghost commented Jan 21, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds the Android Maui Startup scenario to the android_scenarios.proj file and slightly modifies the test.py format to match the new flows arguments. The new flow also enabled the removal of the compilation of the Hello Android app with diagnostics. This work is in tandem with dotnet/performance#2219.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@ghost
Copy link

ghost commented Jan 23, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds the Android Maui Startup scenario to the android_scenarios.proj file and slightly modifies the test.py format to match the new flows arguments. The new flow also enabled the removal of the compilation of the Hello Android app with diagnostics. This work is in tandem with dotnet/performance#2219.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-mono

Milestone: -

@SamMonoRT
Copy link
Member

cc @naricc

@LoopedBard3
Copy link
Member Author

Added iOS for runtime build for package replacement, running a test right now. Will update once setup files are set properly before merge.

@LoopedBard3
Copy link
Member Author

Test succeeded in areas they were likely to affect, and branch was changed back.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit 94f2afb into dotnet:main Jan 31, 2022
LoopedBard3 added a commit to LoopedBard3/runtime that referenced this pull request Feb 8, 2022
* Setup test pipeline for closest possible setup to what is currently working for android startup with the new adb method being used.

* Fix android scenario problems.

* Use latest xharness version for testing popen fix.

* Wrong branch changed.

* Final run setup for runtime part of the repo.

* Use test branch for full run test and keep it until the test finishes.

* Change perf pull branch back to main, hold until test run is complete.

* Add in iOS runtime builds for sure, and change branch for testing.

* Add in the file extraction of the built ios packs and changed workload typo to runtime to better match actual meaning.

* Revert back to main branch for setup.

* Git missed ios-arm runtime extraction, add that in.
@LoopedBard3 LoopedBard3 deleted the MinimalChangesStartupADBRuntime branch March 1, 2022 00:03
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants