-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Create clr.host subset to remove patching step for mono runtime tests #62500
Conversation
Define a 'hosts' component in the CoreCLR build that just builds corerun and coreshim. Define a 'clr.hosts' subset for the toplevel `build.sh`/`build.cmd` scripts Goal is to be able to build corerun without any other native CoreCLR code in order to run tests with Mono
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis pr creates a clr.hosts subset that allows corerun to be built independently from coreclr. It also copies the mono version of libcoreclr to the core_root directory during the runtime test build, so that corerun will use it when running the tests. This simplifies the process of running the runtime tests against mono, by removing the requirement to build coreclr first and the patch it with mono libraries. This should make it easier to reproduce the test runs locally, and also remove a potential source of erros in CI. There will be follow up PRs to enable CI to actually use this. I am sure I must have missed some necessary checks somewhere, but this seems to work locally. This partially addresses #43952 but I will need to do the CI component before that is complete.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits:
- use the
TargetsXYZ
props consistently - we missed tvOS
- style nit:
'$(Cond)' == 'true'
like elsewhere
This pr creates a clr.hosts subset that allows corerun to be built independently from coreclr. It also copies the mono version of libcoreclr to the core_root directory during the runtime test build, so that corerun will use it when running the tests.
This simplifies the process of running the runtime tests against mono, by removing the requirement to build coreclr first and the patch it with mono libraries. This should make it easier to reproduce the test runs locally, and also remove a potential source of erros in CI.
There will be follow up PRs to enable CI to actually use this.
I am sure I must have missed some necessary checks somewhere, but this seems to work locally.
This partially addresses #43952 but I will need to do the CI component before that is complete.
Contributes to #58266