[release/6.0] [mono] win32 implementation of g_get_current_dir #58555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #56163 The getcwd call is returning the string encoded in system character encoding instead of utf-8. Use native GetCurrentDirectoryW call instead and convert to utf-8.
|
Tagging subscribers to this area: Issue DetailsBackport of #58523 to release/6.0 Customer ImpactTestingRisk
|
lambdageek
approved these changes
Sep 2, 2021
marek-safar
approved these changes
Sep 2, 2021
|
Could we get this merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58523 to release/6.0
/cc @lambdageek @radekdoulik
Customer Impact
Android AOT compilation on Windows will fail if the current directory contains non-ASCII characters.
Fixes #56163
Testing
Manual testing
Risk
Low. The issue is only on Windows, and the function in question isn't called from managed code. For AOT compilation, a workaround would be to use a different directory name.