-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix PYTHONPATH on Linux #57701
fix PYTHONPATH on Linux #57701
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Detailsfor issue dotnet/performance#1928
|
@@ -7,7 +7,7 @@ | |||
<CoreRun>%HELIX_CORRELATION_PAYLOAD%\Core_Root\CoreRun.exe</CoreRun> | |||
<BaselineCoreRun>%HELIX_CORRELATION_PAYLOAD%\Baseline_Core_Root\CoreRun.exe</BaselineCoreRun> | |||
|
|||
<HelixPreCommands>$(HelixPreCommands);call %HELIX_CORRELATION_PAYLOAD%\performance\tools\machine-setup.cmd;set PYTHONPATH=%HELIX_WORKITEM_PAYLOAD%\scripts%3B%HELIX_WORKITEM_PAYLOAD%</HelixPreCommands> | |||
<HelixPreCommands>$(HelixPreCommands);call %HELIX_CORRELATION_PAYLOAD%\performance\tools\machine-setup.cmd;export PYTHONPATH=$HELIX_WORKITEM_PAYLOAD/scripts:$HELIX_WORKITEM_PAYLOAD</HelixPreCommands> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are flipped. This block is the Windows path, so should be set
, and the other should be export
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Looked into this a little further. I think this is not the fix that will fix the Earlier in our automation we enable a venv:
The line you're changing is built including this variable
By the time the failure noted in dotnet/performance#1928 happens we have exited the venv. This actually seems to me to be an issue with helix or something else having gone wrong on our machines. (The places added to We need to figure out what is wrong with the machine environment. First Responders may be the right first step. |
…dnceng/internal/_git/dotnet-runtime into alicial/FixPYTHONPATHOnLinux
…dnceng/internal/_git/dotnet-runtime into alicial/FixPYTHONPATHOnLinux
…dnceng/internal/_git/dotnet-runtime into alicial/FixPYTHONPATHOnLinux
@billwert based on the test run at https://dev.azure.com/dnceng/internal/_build/results?buildId=1304705&view=results, looks like the fix works. Even though still have some failures on linux, those needs additional investigation and fixes. |
… the reporter. This avoids a helix crash
Added the same fix for crossgen scenario |
@@ -81,6 +80,7 @@ | |||
|
|||
<PropertyGroup> | |||
<PartitionCount>30</PartitionCount> | |||
<EnableAzurePipelinesReporter>false</EnableAzurePipelinesReporter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently due to some helix recent change, helix reporter crashes due to perf test alters PYTHONPATH. Set EnableAzurePipelinesReporter to false since perf test doesn't use helix reporter to upload test results, instead using perf specific scripts.
for issue dotnet/performance#1928