-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration.Tests
#57422
Conversation
Tagging subscribers to this area: @maryamariyan, @safern Issue DetailsNotes:
|
Thank you. We've generally not been annotating tests, in part because tests purposefully do things that violate contracts. |
@stefannikolei Oh, got it. I've gotten some nullable errors in different test project (options something) in my other PRs, so thought, that tests should be annotated too. If it's not the case, feel free to close this one. PS: When you'll have time, could you please review #57401? Cause I have code ready for other |
Microsoft.Extensions.Configuration.Tests
Microsoft.Extensions.Configuration.Tests
Microsoft.Extensions.Configuration.Tests
# Conflicts: # src/libraries/Microsoft.Extensions.Configuration/tests/Microsoft.Extensions.Configuration.Tests.csproj
Thanks for the PR here, @maxkoshevoi. I'm going to close this since we don't nullable annotate our tests. |
Annotated according to:
Microsoft.Extensions.Configuration
#57414