HttpStress: Optimize LogHttpEventListener #56983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble reproducing #56159 with logging enabled. Still waiting if this change will actually help, but I believe bringing the characteristics of logging test execution closer to non-logging one is worth a quick review.
This PR is eliminating autoflush, blocking calls and Task allocations in
LogHttpEventListener
, which can go expensive, when logging several thousands of lines per sec.Also moving all client log files to subfolder
./clientlog
, since it seems easier to manage but I won't insist on that./cc @ManickaP