Fix stack overflow reporting from native code #56774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stack overflow happens in native code, the stack walker is unable to walk the stack and we end up reporting no call stack at all. This change fixes it by first unwinding the exception context to the first managed frame and then letting the stack walker to walk the frames.
|
cc: @dotnet/dotnet-diag |
|
Hmm, I've forgotten that x86 doesn't have the VirtualUnwindToFirstManagedCallFrame function. That's why the x86 legs failed. |
davidwrighton
approved these changes
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stack overflow happens in native code, the stack walker is unable
to walk the stack and we end up reporting no call stack at all.
This issue was occurring on Windows only, Linux exception handling
unwinds the context to the first managed frame in the HandleHardwareException.
This change fixes it by first unwinding the exception context to the first
managed frame and then letting the stack walker to walk the frames.
Close #46279