Disable failing arm64 win10 Graphics.FromHdc tests #56732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsThese tests have been failing on win10 arm64 builds and are blocking a clean CI. See dotnet/winforms#8829.
|
stephentoub
approved these changes
Aug 2, 2021
safern
reviewed
Aug 2, 2021
| @@ -102,6 +103,12 @@ public static IEnumerable<object[]> FromHdc_TestData() | |||
| [MemberData(nameof(FromHdc_TestData))] | |||
| public void FromHdc_ValidHdc_ReturnsExpected(IntPtr hdc) | |||
| { | |||
| if (PlatformDetection.IsArm64Process && OperatingSystem.IsWindows()) | |||
| { | |||
| // ActiveIssue: 51097 | |||
There was a problem hiding this comment.
Can we instead use the ActiveIssueAttribute that uses a conditional member?
If the condition is true, then it'll skip it. Here is an example:
agocke
approved these changes
Aug 2, 2021
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Aug 3, 2021
* origin/main: (64 commits) [wasm][debugger] Create test Inherited Properties (dotnet#56754) Mark new test as incompatible with GC Mark4781_1GcStressIncompatible (dotnet#56739) Ensure MetadataEnumResult is sufficiently updated by MetaDataImport::Enum (dotnet#56756) [mono] Remove gdb xdebug and binary writer support, it hasn't worked in a while. (dotnet#56759) Update windows-requirements.md (dotnet#56476) Update doc and generic parameter name for JsonValue.GetValue (dotnet#56639) [wasm][debugger] Inspect static class (dotnet#56740) Fix stack overflow handling issue in GC stress (dotnet#56733) Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported (dotnet#56604) Move Windows Compat pack to NuGet pack task (dotnet#56686) Fix build error when building some packages (dotnet#56767) Simplify JIT shutdown logic in crossgen2 (dotnet#56687) Fix race in crossdac publishing with PGO (dotnet#56762) Add DictionaryKeyPolicy support for EnumConverter [dotnet#47765] (dotnet#54429) Use ComWrappers in some Marshal unit-tests and update platform metadata (dotnet#56595) Set `DisableImplicitNamespaceImports_Dotnet=true` to workaround sdk issue (dotnet#56744) Make sure ServerGCHeapDetails is up to date (dotnet#56056) [libraries] Reenable System.Diagnostics.DiagnosticSorce.Switches.Tests on mobile (dotnet#56737) Disable failing arm64 win10 Graphics.FromHdc tests (dotnet#56732) Match xplat event source conditions (dotnet#56435) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have been failing on win10 arm64 builds and are blocking a clean CI.
See dotnet/winforms#8829.
/cc @BruceForstall @hoyosjs