-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use XmlWriter.Create instead of XmlTextWriter #54949
Merged
stephentoub
merged 6 commits into
dotnet:main
from
StephenMolloy:1411-XmlSerializer_throw_on_null_char
Jul 15, 2021
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4487a92
Use a different XmlWriter which will check for invalid characters lik…
StephenMolloy 12c3bae
Bring our XmlReader use into the 21st century as well.
StephenMolloy e3d3bf4
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy 2f43131
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy a10731a
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy 0c0f2b2
Don't need to specify options that are defaults on XmlWriter.
StephenMolloy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -317,9 +317,7 @@ public void Serialize(TextWriter textWriter, object? o) | |
[RequiresUnreferencedCode(TrimSerializationWarning)] | ||
public void Serialize(TextWriter textWriter, object? o, XmlSerializerNamespaces? namespaces) | ||
{ | ||
XmlTextWriter xmlWriter = new XmlTextWriter(textWriter); | ||
xmlWriter.Formatting = Formatting.Indented; | ||
xmlWriter.Indentation = 2; | ||
XmlWriter xmlWriter = XmlWriter.Create(textWriter, new XmlWriterSettings() { Indent = true }); | ||
Serialize(xmlWriter, o, namespaces); | ||
} | ||
|
||
|
@@ -332,9 +330,7 @@ public void Serialize(Stream stream, object? o) | |
[RequiresUnreferencedCode(TrimSerializationWarning)] | ||
public void Serialize(Stream stream, object? o, XmlSerializerNamespaces? namespaces) | ||
{ | ||
XmlTextWriter xmlWriter = new XmlTextWriter(stream, null); | ||
xmlWriter.Formatting = Formatting.Indented; | ||
xmlWriter.Indentation = 2; | ||
XmlWriter xmlWriter = XmlWriter.Create(stream, new XmlWriterSettings() { Indent = true }); | ||
Serialize(xmlWriter, o, namespaces); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for this, skip setting values to the defaults. |
||
} | ||
|
||
|
@@ -421,10 +417,7 @@ private XmlMapping GetMapping() | |
[RequiresUnreferencedCode(TrimDeserializationWarning)] | ||
public object? Deserialize(Stream stream) | ||
{ | ||
XmlTextReader xmlReader = new XmlTextReader(stream); | ||
xmlReader.WhitespaceHandling = WhitespaceHandling.Significant; | ||
xmlReader.Normalization = true; | ||
xmlReader.XmlResolver = null; | ||
XmlReader xmlReader = XmlReader.Create(stream, new XmlReaderSettings() { IgnoreWhitespace = true }); | ||
return Deserialize(xmlReader, null); | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why explicitly set CheckCharacters and IndentChars? You are seeting them to their default values.
Indent
is the only property which you are changing from the default.