Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Off Arm64 Perf Pipeline #54691

Closed
wants to merge 5 commits into from
Closed

Split Off Arm64 Perf Pipeline #54691

wants to merge 5 commits into from

Conversation

Tohron
Copy link
Contributor

@Tohron Tohron commented Jun 24, 2021

It seems there are significantly differing loads between perflab arm64 machines and other perflab machines, thus, the yaml is being split in two so that there can be two separate pipelines.

Since perf_slow was merged separately, this PR now removes those entries from perf.yml.

@ghost
Copy link

ghost commented Jun 24, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

It seems there are significantly differing loads between perflab arm64 machines and other perflab machines, thus, the yaml is being split in two so that there can be two separate pipelines.

Author: Tohron
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@DrewScoggins
Copy link
Member

We are also missing the Windows Arm64 runs that are on the PerfSurfs, and the Mono AOT Arm64 run. Can you please include those in the new yaml file, and remove from the old one.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also include the mono AOT runs in the perf_arm64.yml file.

@DrewScoggins
Copy link
Member

DrewScoggins commented Jun 24, 2021

I think that you should also not rename the perf.yml file, and instead make the perf_x64.yml file a new thing. That way we won't have runs not launching while we are reconfiguring our pipelines. Once we have everything setup the way we like we can go in and delete the perf.yml in another commit.

I chatted with @billwert and we were thinking it might be better to just have the two yml files named perf and perf_slow, since we could end up with non-Arm64 runs in the slow side, and we already have Arm64 runs that we do not want in the Arm64 yaml.

The other piece of this is how we will deploy it. I think the right way to do this is to first check-in an empty perf_slow.yml and get the pipeline configured in AzDO. Then once that is all setup we can move the jobs over. This way we don't have any interruption in lab operation.

@Tohron Tohron force-pushed the split-perf-pipeline branch from 0d2c9a2 to 3b199ab Compare June 29, 2021 16:46
@DrewScoggins
Copy link
Member

DrewScoggins commented Jun 29, 2021

Can you do a private run of this through AzDO, to ensure that we are seeing the right jobs get cut out, and everything else is parsing correctly? Once we have that LGTM

@billwert billwert requested a review from DrewScoggins June 30, 2021 18:08
@Tohron
Copy link
Contributor Author

Tohron commented Jun 30, 2021

Need a new PR since Drew is on vacation

@Tohron Tohron closed this Jun 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants