Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview6] [wasm] Fix blazor/aot builds #54653

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 23, 2021

Backport of #54651 to release/6.0-preview6

/cc @lewing @radical

Customer Impact

Fix a regression in the logic that locates the AOT Cross compiler for Browser builds

Testing

Manual testing

Risk

Very Low, it sets an unset property only used in AOT compilation on wasm.

`dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=`

Make sure this is set for the aot path.
@github-actions github-actions bot requested a review from marek-safar as a code owner June 23, 2021 22:35
@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture labels Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #54651 to release/6.0-preview6

/cc @lewing @radical

Customer Impact

Fix a regression in the logic that locates the AOT Cross compiler for Browser builds

Testing

Manual testing

Risk

Very Low, it sets an unset property only used in AOT compilation on wasm.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Build-mono

Milestone: -

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 23, 2021
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in tactics email

@radical
Copy link
Member

radical commented Jun 24, 2021

runtime (Libraries Test Run release mono OSX x64 Debug) failure is due to #54624

@lewing
Copy link
Member

lewing commented Jun 24, 2021

@mmitche any timeline on when this can be merged?

@lewing
Copy link
Member

lewing commented Jun 24, 2021

maccatalyst timeout is #54678

@steveisok steveisok merged commit 589a29b into release/6.0-preview6 Jun 24, 2021
@jkotas jkotas deleted the backport/pr-54651-to-release/6.0-preview6 branch July 1, 2021 04:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants