[release/6.0-preview6] Fix profiling R2R code on Windows x64 #54369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel requires the function table to be 4-byte aligned.
mangod9
approved these changes
Jun 17, 2021
jeffschwMSFT
approved these changes
Jun 22, 2021
|
@AntonLapounov what are the CI failures? @Anipik once we are ready, can you help us merge this? Thanks |
|
|
|
Looks like we looked at exactly the same time @AntonLapounov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54318 to release/6.0-preview6.
Customer Impact
ReadyToRun code cannot be profiled on Windows x64, because the emitted function table may not be 4-byte aligned. In that case the kernel profiler ignores the function table and fails to unwind the stack. This is a regression caused by switching to Crossgen2 compiler.
Testing
Verified that profiling works with this fix.
Risk
Very low. The fix is a single line that ensures 4-byte alignment of the table.