Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add args descriptions for VNF_MapStore and VNF_MapSelect #54108

Merged

Conversation

SingleAccretion
Copy link
Contributor

For the first-time readers of VNForMapSelectWork's code (like myself), it can be non-obvious why e. g. select(store(m, i, v), i) == v.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 12, 2021
@SingleAccretion SingleAccretion force-pushed the Add-Some-VNFunc-Descriptions branch from ef45376 to 4d7aa03 Compare June 12, 2021 19:48
@SingleAccretion SingleAccretion force-pushed the Add-Some-VNFunc-Descriptions branch from 4d7aa03 to c966181 Compare June 12, 2021 19:50
@tannergooding
Copy link
Member

CC. @briansull, small community PR (just adding a comment to valuenumfuncs)

@sandreenko sandreenko merged commit 9bbf905 into dotnet:main Jun 24, 2021
@SingleAccretion SingleAccretion deleted the Add-Some-VNFunc-Descriptions branch June 24, 2021 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants