Port over TimeZoneInfo.Android.cs #53634
Conversation
|
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsFixes #41867
|
|
Tagging subscribers to this area: @tannergooding |
| @@ -0,0 +1,762 @@ | |||
|
|
|||
There was a problem hiding this comment.
We still need to include the license header:
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.|
|
||
| namespace System { | ||
|
|
||
| interface IAndroidTimeZoneDB { |
There was a problem hiding this comment.
Does this build? I'd have expected some of our static analysis rules to kick in and warn about things like missing visibility.
| return; | ||
| } | ||
|
|
||
| Console.Error.WriteLine ("Couldn't find any tzdata!"); |
There was a problem hiding this comment.
In general we don't want to output to Console. Is this valid on Android only?
| } | ||
|
|
||
| /* | ||
| * Android < v4.3 Timezone support infrastructure. |
There was a problem hiding this comment.
we don't support Android < v4.3 in dotnet/runtime anymore so all of this code can probably go away
| * limitations under the License. | ||
| */ | ||
|
|
||
| #if MONODROID |
There was a problem hiding this comment.
this needs to be removed otherwise none of this code is actually compiled :)
|
The port is going to need a bit of work, so closing for now. |
Fixes #41867