Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPMI dump. #53586

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix SPMI dump. #53586

merged 2 commits into from
Jun 2, 2021

Conversation

sandreenko
Copy link
Contributor

@sandreenko sandreenko commented Jun 2, 2021 •
edited
Loading

Add 2 missed calls to buffer->Unlock() so we can use

SuperPMIShimDebugRec=1
SuperPMIShimDebugRep=1

again, without the change it was failing with:

ERROR: Added item that extended the buffer after it was locked by a call to GetBuffer()

contributes to #53321

@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 2, 2021
@sandreenko sandreenko requested a review from BruceForstall June 2, 2021 10:06
@sandreenko
Copy link
Contributor Author

PTAL @BruceForstall @dotnet/jit-contrib

BruceForstall
BruceForstall approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandreenko sandreenko merged commit 7a4f899 into dotnet:main Jun 2, 2021
@sandreenko sandreenko mentioned this pull request Jun 2, 2021
Merged
@sandreenko sandreenko deleted the fixSPMIlog branch June 2, 2021 23:23
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandreenko @BruceForstall