Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new devirt reason. #53334

Merged
merged 1 commit into from
May 28, 2021
Merged

Add new devirt reason. #53334

merged 1 commit into from
May 28, 2021

Conversation

AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented May 27, 2021 •
edited
Loading

Add new devirtualization (failure) reason for the newly added check.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2021
@AndyAyersMS
Copy link
Member Author

cc @davidwrighton

@runfoapp runfoapp bot mentioned this pull request May 27, 2021
Open
@AndyAyersMS
Copy link
Member Author

@dotnet/jit-contrib feel free to review, it's a simple change.

Test failures are known (#53366).

davidwrighton
davidwrighton approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@davidwrighton davidwrighton merged commit d43e886 into dotnet:main May 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidwrighton davidwrighton davidwrighton approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyAyersMS @davidwrighton