Fix installer tests on runtime-staging #53025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dotnet#52548 some installer tests that were using `PlatformSpecific(TestPlatforms.Windows)` started failing in the runtime-staging pipeline on Linux, even though they shouldn't have been executing. Turns out this is because with dotnet@81771ef we're adding the `-trait category=failing` on the runtime-staging pipeline. This doesn't work since `PlatformSpecific` attribute works by setting the "failing" category. To fix this use a separate trait that can be used to only run the specific tests we want in runtime-staging.
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov Issue DetailsAfter #52548 some installer tests that were using Turns out this is because with 81771ef we're adding the To fix this use a separate trait that can be used to only run the specific tests we want in runtime-staging.
|
ViktorHofer
reviewed
May 20, 2021
ViktorHofer
approved these changes
May 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #52548 some installer tests that were using
PlatformSpecific(TestPlatforms.Windows)started failing in the runtime-staging pipeline on Linux, even though they shouldn't have been executing.Turns out this is because with 81771ef we're adding the
-trait category=failingon the runtime-staging pipeline.This doesn't work since
PlatformSpecificattribute works by setting the "failing" category.To fix this use a separate trait that can be used to only run the specific tests we want in runtime-staging.