Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][tvOS] Remove AOT functional test projects #52574

Merged
merged 1 commit into from
May 11, 2021

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented May 11, 2021

Recently MonoForceInterpreter had been changed to a global property. As a result, iOS.Simulator.Aot.Test.csproj and tvOS.Simulator.Aot.Test.csproj will fail with System.InvalidOperationException: Interpreter and AOT cannot be enabled at the same time. The simulator should not run JIT as default, so an AOT functional test should be run on a device instead.

Fixes #50589

@ghost
Copy link

ghost commented May 11, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Recently MonoForceInterpreter had been changed to a global property. As a result, iOS.Simulator.Aot.Test.csproj and tvOS.Simulator.Aot.Test.csproj will fail with System.InvalidOperationException: Interpreter and AOT cannot be enabled at the same time. The simulator should not run JIT as default, so an AOT functional test should be run on a device instead.

Fixes #50589

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@mdh1418 mdh1418 requested a review from akoeplinger May 11, 2021 00:17
@mdh1418 mdh1418 merged commit 16083f9 into dotnet:main May 11, 2021
@mdh1418 mdh1418 deleted the remove_iOS_tvOS_AOT_test_projects branch May 11, 2021 13:11
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request May 12, 2021
mdh1418 added a commit that referenced this pull request May 12, 2021
* Revert "[iOS][tvOS] Remove AOT functional test projects (#52574)"

This reverts commit 16083f9.

* Cleanup iOS tvOS functional tests and test proj file

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent tvOS test build failures
3 participants