increase timeout for websocket compression tests #52086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsRelates to #52031 This test is failing all the time. In such a situation we should disable or fix it immediately. I don't know why it is timing out, but we should be able to quickly see if it is indeed hanging rather than just slow.
|
|
/azp help |
This comment has been minimized.
This comment has been minimized.
|
/azp list |
This comment has been minimized.
This comment has been minimized.
|
I made it 30 seconds for everything as it's not quite only ARM. Also, it should never make a passing test any slower. TestResults
| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Finished >= datetime(2021-3-1 0:00:00)
//and Type == "System.Net.WebSockets.Tests.WebSocketDeflateTests"
and Method == "PayloadShouldHaveSimilarSizeWhenSplitIntoSegments"
//and Result == 'Fail'
//and QueueName1 contains "arm"
| summarize count() by Result, QueueAlias, Arguments, Message //, bin(Duration, 1)
|
|
I notice in the above table that it's always window bits 14 or 15, and (judging by the identical numbers) when it fails for one it always fails for the other. I also now notice that @CarnaViire already pointed this out :) I will update this to skip 14 and 15 while this is investigated. |
|
I also should have filtered out PR validation: TestResults
| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Finished >= datetime(2021-3-1 0:00:00)
and Type == "System.Net.WebSockets.Tests.WebSocketDeflateTests"
and Branch == "refs/heads/main"
| summarize count() by Method, Result, QueueAlias, Arguments, Message //, bin(Duration, 1)
|
|
The Android failures above show that resources were not loaded. That's clearly unrelated and no doubt we'll see it again if it's not fixed. |
CarnaViire
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #52031
This test is failing all the time. In such a situation we should disable or fix it immediately.
I don't know why it is timing out, but we should be able to quickly see if it is indeed hanging rather than just slow.