Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over the runtime outerloop pipeline to use Crossgen2 #51444

Closed
wants to merge 1 commit into from

Conversation

trylek
Copy link
Member

@trylek trylek commented Apr 17, 2021

With this change, the only remaining pipelines using Crossgen1 are
"r2r.yml", "r2r-extra.yml" and "release-tests.yml". I haven't yet
identified the pipeline running the "release-tests.yml" script;
for the "r2r*.yml", these now remain the only pipelines exercising
Crossgen1. I don't think it makes sense to switch them over to
CG2 as we already have their CG2 counterparts; my expectation is
that, once CG1 is finally decommissioned, they will be just deleted.

Thanks

Tomas

/cc @dotnet/crossgen-contrib @dotnet/runtime-infrastructure

With this change, the only remaining pipelines using Crossgen1 are
"r2r.yml", "r2r-extra.yml" and "release-tests.yml". I haven't yet
identified the pipeline running the "release-tests.yml" script;
for the "r2r*.yml", these now remain the only pipelines exercising
Crossgen1. I don't think it makes sense to switch them over to
CG2 as we already have their CG2 counterparts; my expectation is
that, once CG1 is finally decommissioned, they will be just deleted.

Thanks

Tomas
@trylek trylek added this to the 6.0.0 milestone Apr 17, 2021
@trylek trylek requested a review from mangod9 April 17, 2021 18:52
Copy link
Member

@mangod9 mangod9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this over

@trylek
Copy link
Member Author

trylek commented Apr 18, 2021

Thanks Manish for the review. One more hurdle here is that this change is actually blocked on

#51416

as otherwise several outerloop tests fail on x86 and arm - we have always run the Crossgen2 outerloop tests on x64 / arm64 only, for 32-bit platforms we have just the "comparison runs" which apparently don't cover all the corner cases. I don't think it's super important to beef up the existing Crossgen2 testing as this PR is going to fill that coverage gap, it's just that we need to maintain the proper sequencing to keep CI healthy.

@trylek
Copy link
Member Author

trylek commented Apr 22, 2021

I have combined the change with the PR #51416 fixing the regression test 46239 and a few other issues as otherwise merging this in would break the outerloop runs with these errors.

@trylek trylek closed this Apr 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2021
@trylek trylek deleted the CI-CG2 branch January 10, 2022 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants