Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure System.Resources.Extensions targets are applied transitively #50288

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Mar 26, 2021

Copy targets to buildTransitive so that they will be applied from
transitive package/project references. We maintain build folder so that
old nuget clients can still get the build targets.

Fixes #50286

Copy targets to buildTransitive so that they will be applied from
transitive package/project references.  We maintain build folder so that
old nuget clients can still get the build targets.
@ghost
Copy link

ghost commented Mar 26, 2021

Tagging subscribers to this area: @tarekgh, @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Copy targets to buildTransitive so that they will be applied from
transitive package/project references. We maintain build folder so that
old nuget clients can still get the build targets.

Fixes #50286

Author: ericstj
Assignees: ericstj
Labels:

area-System.Resources

Milestone: -

@ericstj
Copy link
Member Author

ericstj commented Mar 26, 2021

For reference here is the buildTransitive spec: https://github.com/NuGet/Home/wiki/Allow-package--authors-to-define-build-assets-transitive-behavior#solution

Duplicating targets is the "best practice" here for back-compat.

@ericstj
Copy link
Member Author

ericstj commented Mar 26, 2021

Thanks @jnm2 for the great report of this issue.

@ghost
Copy link

ghost commented Mar 26, 2021

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 8 seconds. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ericstj
Copy link
Member Author

ericstj commented Mar 26, 2021

Opened #50300 to track the mono failure. Looks interesting 🤨 not related to this change though.

@ericstj ericstj merged commit f557467 into dotnet:main Mar 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants