Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default features flags to match to Android SDK defaults #49005

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Set default features flags to match to Android SDK defaults #49005

merged 1 commit into from
Mar 3, 2021

Conversation

MaximLipnin
Copy link
Contributor

@ghost
Copy link

ghost commented Mar 2, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #43865.

Based on https://github.com/xamarin/xamarin-android/blob/master/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets#L64-L76

Author: MaximLipnin
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

steveisok
steveisok approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important to keep in mind that if we add HttpClient based functional tests, we will need to bring in XA assemblies.

This is due to <UseNativeHttpHandler>true</UseNativeHttpHandler>

@steveisok steveisok merged commit 7f491db into dotnet:main Mar 3, 2021
@MaximLipnin MaximLipnin deleted the add_android_runtime_defaults branch March 4, 2021 08:26
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@mdh1418 mdh1418 Awaiting requested review from mdh1418

Assignees
No one assigned
Labels
area-Infrastructure-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximLipnin @marek-safar @steveisok @karelz